fix(cron): report missing default model clearly#46072
Open
szzhoujiarui-sketch wants to merge 1 commit into
Open
fix(cron): report missing default model clearly#46072szzhoujiarui-sketch wants to merge 1 commit into
szzhoujiarui-sketch wants to merge 1 commit into
Conversation
Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cron jobs can currently fall through to provider execution with an empty model when
config.yamlhas amodel:section but omitsmodel.default. That produces a lower-level provider/API error that is harder to diagnose.This PR makes the cron path fail before starting
AIAgentwhen no job model,HERMES_MODEL, ormodel.defaultresolves to a non-empty model. The error now points directly at the missing cron model configuration.Related Issue
Fixes #43899
Type of Change
Changes Made
cron/scheduler.py: detect the explicitmodel:dict-without-default case and return a clear Hermes-side error before agent startup.tests/cron/test_scheduler.py: add coverage that the missing default model path fails early and does not instantiateAIAgent.How to Test
config.yamlwithmodel.providerset and nomodel.default.No model resolved for cron job...before the provider call.Tested locally:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — N/Acli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AScreenshots / Logs
Focused test result: