fix(desktop): bind new-session profile to active gateway profile#45010
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(desktop): bind new-session profile to active gateway profile#45010liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
When the Desktop app creates a new session via the sidebar "New Session" button or Ctrl/Cmd+N, it sets $newChatProfile to null. The server interprets a missing/null profile as the launch profile (typically "default"), which silently creates the session in the wrong profile when the user has explicitly selected a different profile in the rail. Fix: set $newChatProfile to $activeGatewayProfile.get() instead of null, so the new session binds to whatever profile the user is currently viewing. Fixes NousResearch#45000
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes new sessions being created in the launch profile (typically
default) instead of the user's actively selected profile when using the Desktop sidebar "New Session" button or Ctrl/Cmd+N shortcut in app-global remote mode.Related Issue
Fixes #45000
Type of Change
Changes Made
apps/desktop/src/app/chat/sidebar/index.tsx: Set$newChatProfileto$activeGatewayProfile.get()instead ofnullwhen creating a plain new session. Added$activeGatewayProfileto the import from@/store/profile.apps/desktop/src/app/hooks/use-keybinds.ts: Same fix for the Ctrl/Cmd+N keyboard shortcut handler. Added$activeGatewayProfileto the import from@/store/profile.How to Test
defaultandlab).labprofile in the profile rail — the sidebar should showlab's sessions.lab, notdefault.state.dbin thelabprofile's HERMES_HOME to confirm the session persisted there.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ACode Intelligence
apps/desktop/src/store/profile.ts($activeGatewayProfile atom, exported asatom<string>('default'))tui_gateway/server.py(session.create handler, line ~3605: "None/own profile → launch")$newChatProfileatom stores the profile for the next new chat session;nullwas intended to mean "use current live profile" but the server interpreted it as the launch profile.