fix(cli): resolve session ID before delete like GET/PATCH do (#44117)#44273
Open
kyssta-exe wants to merge 1 commit into
Open
fix(cli): resolve session ID before delete like GET/PATCH do (#44117)#44273kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44117. The DELETE /api/sessions/{id} endpoint did raw WHERE id=? lookup without resolving the session ID first, unlike the GET and PATCH endpoints which use resolve_session_id() for prefix/alias/compression-root resolution. This caused 'session not found' errors when the frontend held a compression lineage root ID or short prefix that needed resolution.