fix: include plugin platforms in status#44255
Open
Rivuza wants to merge 1 commit into
Open
Conversation
Trigger plugin discovery before reading platform_registry.plugin_entries() in hermes status so third-party platform adapters registered by plugins appear in the Messaging Platforms section.\n\nAdd regression coverage with a plugin-registered test platform.\n\nCloses NousResearch#44119
Contributor
✅ Verification: Clean ReviewReviewed this PR's diff. The fix correctly addresses the missing plugin platforms in
No issues found. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes statusreads plugin-registered platform entriesTest Plan
/home/rivuza/hermes-agent/.venv/bin/python -m pytest tests/hermes_cli/test_status.py::test_show_status_includes_plugin_registered_platform -q/home/rivuza/hermes-agent/.venv/bin/python -m pytest tests/hermes_cli/test_status.py -qCloses #44119