fix(dashboard): don't force /opt/data files root for remote requests on host installs#44139
Open
AIalliAI wants to merge 1 commit into
Open
fix(dashboard): don't force /opt/data files root for remote requests on host installs#44139AIalliAI wants to merge 1 commit into
AIalliAI wants to merge 1 commit into
Conversation
…on host installs
The managed-files policy treated every non-local dashboard request as a
hosted (Docker) deployment and locked the Files tab to /opt/data. On a
plain host install reached over the LAN, that path doesn't exist (or
isn't readable by the dashboard user), so the Files tab returned a 500:
{"detail": "Managed files root is unavailable: [Errno 13] Permission denied: '/opt/data'"}
The hosted layout is already detected directly via HERMES_HOME resolving
to /opt/data, so use only that signal to apply the /opt/data lock.
Remote and auth-gated requests on host installs keep a locked root —
the dashboard user's home — preserving the previous confinement posture
without pointing at a Docker-only path.
Fixes NousResearch#44116
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
12 tasks
This was referenced Jun 11, 2026
Contributor
Author
|
Requesting maintainer review — this is ready to land from my side. Standalone fork CI is pending first-run approval here; the rollup branch in #44061 carrying this session's batch is fully green on upstream CI (all test shards, typecheck, e2e). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44116
On a non-Docker host install, opening the dashboard Files tab from another machine on the LAN returned a 500:
{"detail":"Managed files root is unavailable: [Errno 13] Permission denied: '/opt/data'"}_managed_files_policytreated any non-local request (remote client, orauth_requiredset) as a hosted deployment and locked the managed-files root to/opt/data— a path that only exists in the Docker/hosted filesystem layout.Change
/opt/datalock now applies only when the install actually uses the hosted layout, detected via the existing_default_hermes_root_is_opt_data()check (HERMES_HOMEresolving to/opt/data, which the official Docker setup sets).locked_root=home,can_change_path=False) — so the previous confinement posture for non-local clients is preserved, just no longer pointing at a Docker-only path. Local requests keep the existing unlocked home policy.HERMES_DASHBOARD_FILES_ROOTcontinues to override everything, so the workaround from the issue keeps working.Tests
Added to
tests/hermes_cli/test_web_server_files.py:HERMES_HOME) → policy locks to home, no 500auth_required=Trueon a host install → policy locks to homeHERMES_HOME=/opt/data→ still locked to/opt/data(hosted behavior unchanged)pytest tests/hermes_cli/ -k web_server: 306 passed; the one failure (test_skills_list_without_profile_uses_dashboard_home) is a pre-existing test-ordering flake that also fails on unmodifiedmainand passes in isolation.🤖 Generated with Claude Code