fix(gateway): exit non-zero on macOS launchd restart path (#43475)#43596
Open
kyssta-exe wants to merge 1 commit into
Open
fix(gateway): exit non-zero on macOS launchd restart path (#43475)#43596kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
Collaborator
|
Related: #43498 (competing fix for the same issue #43475). Both make the gateway exit non-zero so launchd's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43475. On macOS, /restart used the detached path (via_service=False) which skipped setting the exit code. launchd's KeepAlive.SuccessfulExit=false requires a non-zero exit to relaunch the process. Added an elif branch to set exit code 75 on macOS when via_service is False.