feat(desktop): add native OS notification when agent response is ready#43255
Open
liuhao1024 wants to merge 1 commit into
Open
feat(desktop): add native OS notification when agent response is ready#43255liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
When the user minimizes Hermes Desktop or switches to another window, there is no system notification when the agent finishes processing. This PR adds a native OS notification (Electron Notification API) that fires on when the window is not focused. Changes: - Add nanostore with localStorage persistence - Fire native notification on message.complete when window is unfocused - Add settings toggle in Appearance section - Add i18n strings (en, zh) - Add 5 unit tests Closes NousResearch#43225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the user minimizes Hermes Desktop or switches to another application, there is no system notification when the agent finishes processing. The user must manually switch back to check.
Competing tools like OpenAI Codex and WorkBuddy send native OS notifications when the agent completes its turn.
Solution
Fire a native OS notification (via Electron's
NotificationAPI, already wired inpreload.cjs→main.cjs) when:message.completeevent)!document.hasFocus())Changes
store/desktop-notifications.ts$desktopNotificationsEnablednanostore with localStorage persistenceuse-message-stream.tsmessage.completewhen window is unfocusedappearance-settings.tsxi18n/types.tsi18n/en.tsi18n/zh.tsdesktop-notifications.test.tsNotification behavior
Screenshots
The toggle appears in Settings → Appearance, below the "Tool Call Display" option.
Closes #43225