fix(cli): use atomic write in save_config_value to prevent config loss on interrupt#4320
Merged
Conversation
…s on interrupt save_config_value() used bare open(path, 'w') + yaml.dump() which truncates the file to zero bytes on open. If the process is interrupted mid-write, config.yaml is left empty. Replace with atomic_yaml_write() (temp file + fsync + os.replace), matching the gateway config write path. Co-authored-by: Hermes Agent <hermes@nousresearch.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #4276 by @binhnt92 — atomic write for
save_config_value().save_config_value()in cli.py used bareopen(path, 'w')+yaml.dump(). The'w'mode truncates the file to zero bytes before writing — if the process is interrupted mid-write, config.yaml is left empty. Replaced withatomic_yaml_write()(temp file + fsync + os.replace), matching thesave_config()path inhermes_cli/config.py.Changes
save_config_value()now usesatomic_yaml_write()(cherry-picked from fix(cli): use atomic write in save_config_value to prevent config loss on interrupt #4276)Original contributor's tests replaced — they parsed source code for string patterns which is brittle.