fix(cli): allow empty strings and falsy values in config set#4301
Closed
dsr-restyn wants to merge 1 commit into
Closed
fix(cli): allow empty strings and falsy values in config set#4301dsr-restyn wants to merge 1 commit into
dsr-restyn wants to merge 1 commit into
Conversation
`hermes config set KEY ""` and `hermes config set KEY 0` were rejected because the guard used `not value` which is truthy for empty strings, zero, and False. Changed to `value is None` so only truly missing arguments are rejected. Closes NousResearch#4277 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Merged via PR #4310. Your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks @dsr-restyn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes config set KEY ""prints usage and exits instead of setting the value. The guard athermes_cli/config.py:2043usesnot value, which is truthy for"","0", andFalse. Users cannot blank stale config values via the CLI — they have to manually edit config.yaml.Reported by a user who needed to clear
OPENROUTER_API_KEYafter migrating to a local Ollama endpoint.Closes #4277
Changes
hermes_cli/config.py: Changednot value→value is Nonein theconfig_commandset guard. Argparse givesNonewhen the positional is omitted (nargs="?"), so this correctly rejects missing arguments while accepting empty strings and zerotests/hermes_cli/test_set_config_value.py: 5 new regression tests — empty string to .env, empty string to config.yaml, zero to config.yaml, missing value rejection, andconfig_commandentry point acceptanceTesting
test_set_config_value.py(26 existing + 5 new)config set model ""writesmodel: '',config set OPENROUTER_API_KEY ""writesOPENROUTER_API_KEY=,config set verbose 0writesverbose: 0, and omitting the value arg still prints usage and exits