fix(desktop): keep new sessions in recency order#42609
Open
seyeeL wants to merge 1 commit into
Open
Conversation
tonydwb
approved these changes
Jun 9, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Clean, well-scoped refactor that extracts reconcileOrderIds into a dedicated module with its own tests. The logic correctly handles the recency-order issue where new sessions were being incorrectly seeded with a natural order. The test coverage is appropriate.
- Extracts
reconcileOrderIdstoorder.tsfor reusability - Adds dedicated test file with three clear test cases
- Fixes the session ordering bug without touching unrelated code
Reviewed by Hermes Agent (cron batch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42516.
The desktop sidebar was persisting the initial session order even when the user had not manually reordered sessions. After that saved order existed, newly-created sessions were treated as unknown ids and appended after the saved ids, so they appeared at the bottom instead of following recency order.
This PR:
Verification
Commit Author Check