fix(tests): isolate global SOUL.md in test_empty_dir_returns_empty#426
Closed
teyrebaz33 wants to merge 2 commits into
Closed
fix(tests): isolate global SOUL.md in test_empty_dir_returns_empty#426teyrebaz33 wants to merge 2 commits into
teyrebaz33 wants to merge 2 commits into
Conversation
Thin skill file that wraps the pokemon-agent pip package. All emulation logic lives in NousResearch/pokemon-agent. - Gameplay loop: observe/orient/decide/act/verify/record/save - Battle strategy with Gen 1 quirks and type chart - Memory conventions with PKM: prefix - Progression milestones (all 8 badges + Elite Four) - Session save/load lifecycle - Dashboard reference (localhost:8765/dashboard)
The test was failing when ~/.hermes/SOUL.md exists on the system because build_context_files_prompt() falls back to the global SOUL.md when none is found in cwd. Added monkeypatch to redirect Path.home() to tmp_path so the test is fully isolated.
Contributor
|
This was already fixed independently in commit 2a68099 ( Also note: this PR bundles an unrelated Pokemon player skill that shouldn't be in a test-fix PR. Closing as already resolved. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_empty_dir_returns_emptywas failing on any system where~/.hermes/SOUL.mdexists. The functionbuild_context_files_prompt()correctly falls back to the global~/.hermes/SOUL.mdwhen no SOUL.md is found in cwd — but the test didn't account for this, so it failed with a non-empty result.Fix
Added
monkeypatchto redirectPath.home()totmp_pathso the test is fully isolated from the user's home directory.Reproduce
Result after fix