fix(mattermost): resolve thread follow-ups and tool output leaks (#4221)#4230
Open
devorun wants to merge 1 commit into
Open
fix(mattermost): resolve thread follow-ups and tool output leaks (#4221)#4230devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4221 — Mattermost threaded conversations broken in two ways.
1. Tool/reasoning output leaking to main channel
The
sendmethod now falls back tometadata.get("thread_id")whenreply_tois not set, using it asroot_idin the payload. All tool and processing output now stays inside the thread.2. Follow-up messages ignored inside threads
Added
_known_threadsset to the adapter. When the bot posts into a thread, it registers that thread's ID. In_handle_ws_event, incoming messages from known threads bypass the@mentiongate and continue the conversation naturally.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs