fix(gateway): use OGG for Telegram auto-TTS voice replies#41644
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-import |
1 |
First entries
tests/gateway/test_auto_voice_reply_format.py:7: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
✅ Fixed issues: none
Unchanged: 5198 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telegram auto-TTS voice replies now send as native voice bubbles instead of plain file attachments.
Telegram's
send_voiceadapter path only renders a native voice bubble for OGG/Opus;.mp3silently falls through tosend_audio(a file attachment). The gateway auto-TTS path in_send_voice_reply()hardcoded a.mp3output path, bypassing Telegram-aware format selection.Changes
gateway/run.py: request.oggoutput when the platform is Telegram, keep.mp3for all other platforms.tests/gateway/test_auto_voice_reply_format.py: new regression tests (Telegram → ogg, Slack → mp3).scripts/release.py: addgilad@smiti.ai → giladbautoAUTHOR_MAP(CI author gate).Validation
.mp3→send_audio(file attachment).ogg→send_voice(voice bubble).mp3.mp3(unchanged)tests/gateway/test_auto_voice_reply_format.py— 2 passed.Salvaged from #20182 by @giladbau (Gilad Bauman); authorship preserved via cherry-pick.
Infographic