fix(setup): use npm ci instead of npm install in hermes update#4114
Open
shannonsands wants to merge 1 commit into
Open
fix(setup): use npm ci instead of npm install in hermes update#4114shannonsands wants to merge 1 commit into
shannonsands wants to merge 1 commit into
Conversation
npm install re-resolves the dependency graph and rewrites package-lock.json, leaving a dirty working tree after every update. npm ci installs exactly from the committed lockfile without mutating it, which is the correct command for reproducible installs in update/deployment contexts. Closes #4048
This was referenced Apr 23, 2026
Collaborator
|
Likely duplicate of already-merged #16295 which applied the same npm install → npm ci fix to hermes update. |
1 similar comment
Collaborator
|
Likely duplicate of already-merged #16295 which applied the same npm install → npm ci fix to hermes update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
npm install --silentwithnpm ci --silentin thehermes updatecommand.npm installre-resolves the dependency graph and rewritespackage-lock.json, leaving a dirty working tree after every update.npm ciinstalls exactly from the committed lockfile without mutating it.Related Issue
Fixes #4048
Type of Change
Changes Made
hermes_cli/main.pyline 3041:npm install --silent→npm ci --silentOne line changed. The WhatsApp bridge
npm install(line 742) is intentionally left as-is — that is an initial install into an emptynode_modules/, wherenpm installis correct.How to Test
Checklist
Code
pytest tests/ -qand all tests pass — N/A (one-line behavioral change in update command)Documentation & Housekeeping
cli-config.yaml.example— N/ACONTRIBUTING.mdorAGENTS.md— N/Anpm ciis available on all platforms with npm 5.7+