Skip to content

fix: harden Windows portability tests and paths#40891

Open
eliaschofo wants to merge 16 commits into
NousResearch:mainfrom
eliaschofo:hermes-dep-hygiene-local
Open

fix: harden Windows portability tests and paths#40891
eliaschofo wants to merge 16 commits into
NousResearch:mainfrom
eliaschofo:hermes-dep-hygiene-local

Conversation

@eliaschofo

Copy link
Copy Markdown

Summary

  • Fixes Windows path/URI handling regressions across ACP, image/cache helpers, file-safety, shell hooks, and skill/supporting-path display.
  • Makes Windows-specific/cross-platform tests deterministic by avoiding live shell/PATH dependencies in inline-shell skill-command tests.
  • Fixes terminal subdirectory hint extraction for Windows backslash paths.

Test Plan

  • Windows: python -m pytest tests\agent\test_external_skills.py tests\agent\test_skill_commands.py::TestInlineShellExpansion::test_inline_shell_runs_when_enabled -q -o addopts="" --tb=short → 12 passed.
  • Windows: python -m pytest tests\agent\test_skill_commands.py tests\agent\test_external_skills.py tests\agent\test_external_skills_dirs_cache.py -q -o addopts="" --tb=short → 58 passed.
  • Windows: python -m pytest tests\agent\test_subdirectory_hints.py tests\agent\test_skill_commands.py tests\agent\test_external_skills.py tests\agent\test_external_skills_dirs_cache.py -q -o addopts="" --tb=short → 83 passed.
  • Windows: python -m pytest tests\agent -q -o addopts= -m "not integration" --maxfail=1 --tb=short → 3914 passed, 14 skipped.

@eliaschofo eliaschofo requested a review from a team June 7, 2026 00:58
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have area/config Config system, migrations, profiles labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles P3 Low — cosmetic, nice to have type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants