fix(cli): dedupe .env keys in save_env_value#40753
Open
chrislazar25 wants to merge 1 commit into
Open
Conversation
save_env_value() only updated the first matching line in .env, then broke out of the loop. python-dotenv resolves env vars with last-occurrence-wins semantics, so any stale duplicate key lower in the file silently shadowed the corrected value. Fix: remove the break so ALL matching lines are updated. Duplicate keys get the same value, eliminating the shadowing. Tests added for both the fix and a regression case. Fixes NousResearch#8270
d5019e7 to
910f879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_env_value() only updated the first KEY= value it found in .env, then stopped. But python-dotenv reads with last-occurrence-wins semantics, so if you had two OPENROUTER_API_KEY lines, the second (stale) one always won at runtime - even though save_env_value wrote the correct value to the first line.
The fix is removing the break in save_env_value() so every matching line gets updated. No more shadowing.
How to test:
Platforms tested:
Linux (Pop!_OS 22.04). Standard file I/O - works on macOS, Linux, and WSL2.
Fixes #8270