chore(config): remove stale auxiliary.skills_hub LLM slot (#40703)#40710
Open
aimanmalib wants to merge 1 commit into
Open
chore(config): remove stale auxiliary.skills_hub LLM slot (#40703)#40710aimanmalib wants to merge 1 commit into
aimanmalib wants to merge 1 commit into
Conversation
…ch#40703) Skills Hub routes through deterministic library paths (tools/skills_hub.py + hermes_cli/skills_hub.py) and has no call_llm(task="skills_hub") call site, so the auxiliary.skills_hub provider/model slot is a no-op. This mirrors the session_search cleanup (PR NousResearch#27590/NousResearch#30382) after that tool became DB-backed. Removes the dead slot from: - DEFAULT_CONFIG["auxiliary"] (hermes_cli/config.py) + explanatory note - the aux model picker _AUX_TASKS (hermes_cli/main.py) - _AUX_TASK_SLOTS (hermes_cli/web_server.py) - stale docstrings (agent/auxiliary_client.py, hermes_cli/plugins.py) - docs (configuration.md, fallback-providers.md) Side effect: 'skills_hub' is no longer a reserved built-in aux key (the reserved set is derived from _AUX_TASKS), so plugins may now register it — same end state as session_search. Test updated accordingly. The real Skills Hub feature (tools/skills_hub.py, the /skills command) is untouched. 91 related tests pass.
0aef803 to
9fddfb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the stale
auxiliary.skills_hubLLM slot. Closes #40703.Why
auxiliary.skills_hubis exposed like a configurable auxiliary-LLM slot, but there is no runtime call site usingcall_llm(task="skills_hub")/async_call_llm(task="skills_hub"). Skills Hub routes entirely through deterministic library paths (tools/skills_hub.py+hermes_cli/skills_hub.py), so settingauxiliary.skills_hub.provider/modelis a silent no-op.This is the same situation as
session_search, which was removed from the aux config after PR #27590 made it DB-backed (picker slot cleaned up in PR #30382). This change bringsskills_hubto the same end state.I verified there is no
call_llm/async_call_llmcall site for theskills_hubtask before removing anything.Changes
hermes_cli/config.py— drop the deadauxiliary.skills_hubblock fromDEFAULT_CONFIG; add an explanatory note mirroring the existingsession_searchnote. Leftover values in userconfig.yamlfiles remain harmless/ignored.hermes_cli/main.py— remove theskills_hubrow from the_AUX_TASKSmodel picker.hermes_cli/web_server.py— removeskills_hubfrom_AUX_TASK_SLOTS.agent/auxiliary_client.py— update two stale docstring/comment references (the task-list docstring also still listed the already-removedsession_search).hermes_cli/plugins.py— update the reserved-key docstring.configuration.mdandfallback-providers.md.Side effect:
skills_hubis no longer a reserved aux keyThe plugin reserved-key set is derived from
_AUX_TASKS(builtin_keys = {k for k, _, _ in _BUILTIN_AUX_TASKS}), so removing the picker row also freesskills_hubfor plugin registration — exactly the same end state assession_search. Updatedtests/hermes_cli/test_plugin_auxiliary_tasks.pyaccordingly.Not touched
The real Skills Hub feature is untouched —
tools/skills_hub.py,hermes_cli/skills_hub.py, the/skillscommand, the web dashboard hub endpoints, andTRUSTED_REPOS.Tests
Updated the reserved-builtin-keys test. Verified locally:
Also confirmed
DEFAULT_CONFIG["auxiliary"]no longer containsskills_huband the key is no longer reserved (matchingsession_search).