fix(memory): increment retrieval_count on search results in holographic memory (#17899)#39664
Open
dusterbloom wants to merge 1 commit into
Open
fix(memory): increment retrieval_count on search results in holographic memory (#17899)#39664dusterbloom wants to merge 1 commit into
dusterbloom wants to merge 1 commit into
Conversation
…ic memory (NousResearch#17899) FactRetriever.search() bypassed store.search_facts(), the only place that bumped retrieval_count. The counter was always 0. Fix: increment retrieval_count directly in FactRetriever.search() for returned facts, with silent error handling. Closes NousResearch#17899
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17899
FactRetriever.search() bypassed store.search_facts(), the only place that bumped retrieval_count. The counter was always 0.
Fix: Increment retrieval_count directly in FactRetriever.search() for returned facts, with silent error handling.
Tests: 3 tests — increments on search, accumulates across multiple searches, unrelated facts stay at 0.
This was originally part of #23221 — split into focused single-fix PRs for easier review.