Skip to content

fix: remove redundant _turn_exit_reason assignment#38233

Closed
alaamohanad169-ship-it wants to merge 1 commit into
NousResearch:mainfrom
alaamohanad169-ship-it:fix/issue-38162-dead-code
Closed

fix: remove redundant _turn_exit_reason assignment#38233
alaamohanad169-ship-it wants to merge 1 commit into
NousResearch:mainfrom
alaamohanad169-ship-it:fix/issue-38162-dead-code

Conversation

@alaamohanad169-ship-it

Copy link
Copy Markdown
Contributor

Closes #38162

The line '_turn_exit_reason = "budget_exhausted"' is redundant because the variable is unconditionally overwritten by 'max_iterations_reached(...)' on the very next lines. Removing it has no behavioral effect.

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/agent Core agent loop, run_agent.py, prompt builder labels Jun 3, 2026
@alaamohanad169-ship-it alaamohanad169-ship-it marked this pull request as ready for review June 5, 2026 06:41
@alaamohanad169-ship-it alaamohanad169-ship-it deleted the fix/issue-38162-dead-code branch June 6, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: _turn_exit_reason = "budget_exhausted" is redundant in run_conversation of conversation_loop.py

2 participants