fix(desktop): add @testing-library/dom as explicit dev dependency#38208
Merged
Conversation
@testing-library/react@16 declares @testing-library/dom as a peerDependency and re-exports waitFor/fireEvent/screen/within from it. Without dom installed as a direct dependency, tsc -b fails with TS2305 in every test file that imports those names — which breaks the apps/desktop build during installer bootstrap (Hermes Setup → "INSTALL DIDN'T FINISH").
- Add @testing-library/dom to apps/desktop devDeps in package-lock.json so npm ci validates against the manifest change (contributor left the lockfile out of the PR intentionally). - Removes stale 'peer: true' flags now that dom is an explicit devDep. - AUTHOR_MAP: prostoandrei9@gmail.com -> vladkvlchk (CI author gate).
Lockfile regeneration invalidated the flake's pinned npm-deps hash. Hash taken from fetchNpmDeps' authoritative 'got:' line (the prefetch-npm-deps Diagnose helper reports a different, wrong value due to a fetcherVersion normalization discrepancy).
999c88d to
e89202d
Compare
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS bootstrap installer crash ("INSTALL DIDN'T FINISH", issue #36980): the desktop
tsc -bstep failed with ~20 TS2305 errors because test files importwaitFor/fireEvent/screen/withinfrom@testing-library/react, which re-exports them from@testing-library/dom— declared only as a peer dep, so npm never installed it.Salvage of #36978 by @vladkvlchk onto current main, with the lockfile regenerated so CI
npm civalidates.Changes
@testing-library/dom@^10.4.0to devDependencies (contributor's commit).@testing-library/domin the apps/desktop devDeps block; drops now-stalepeer: trueflags (follow-up).prostoandrei9@gmail.com->vladkvlchk(follow-up).Validation
tsc -b(desktop)Closes #36978.
Infographic