fix(launchd): raise gateway file descriptor limit#38086
Open
sweetcornna wants to merge 1 commit into
Open
Conversation
bf3dcf3 to
5666697
Compare
This was referenced Jun 7, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30230.
Summary:
SoftResourceLimitsandHardResourceLimitsforNumberOfFiles=4096to the generated gateway plist.KeepAliveshape while adding the fd limits.Verification:
python -m pytest tests/hermes_cli/test_gateway_service.py::TestProfileArg::test_launchd_plist_raises_file_descriptor_limit -qwas the original red test on macOS before the plist change..venv\\Scripts\\python.exe -m pytest tests/hermes_cli/test_gateway_service.py::TestProfileArg::test_launchd_plist_raises_file_descriptor_limit -q --timeout-method=thread-> skipped on Windows because the module imports POSIXpwd/grp..venv\\Scripts\\python.exe -m pytest tests/hermes_cli/test_gateway_service.py -q -k "launchd or ProfileArg" --timeout-method=thread-> skipped on Windows for the same module-level POSIX import.generate_launchd_plist()-> confirmedSoftResourceLimits,HardResourceLimits, twoNumberOfFileskeys, and<integer>4096</integer>..venv\\Scripts\\python.exe -m ruff check hermes_cli/gateway.py tests/hermes_cli/test_gateway_service.py-> passed.git diff --check-> passed.Note: full
tests/hermes_cli/test_gateway_service.pystill needs a POSIX/macOS host to execute rather than skip.