fix(gateway): start Matrix mautrix syncer#37807
Closed
konsisumer wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing this. CI here is red from a self-introduced regression — the |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Matrix gateway receive path by starting mautrix's own syncer after handlers are registered. Direct
client.sync()calls return sync payloads but do not driveadd_event_handler(...)callbacks, which left the adapter connected and able to send while never responding to incoming Matrix messages.Related Issue
Fixes #7914
Type of Change
Changes Made
gateway/platforms/matrix.py: startclient.start(None)after auth, handler registration, initial sync, and initial key sharing; stop the mautrix syncer during disconnect; keep the Hermes background task for joined-room/DM/key-share maintenance instead of direct event-dispatch sync polling.tests/gateway/test_matrix.py: update the fake mautrix client, replace stale direct-sync-loop expectations, and add lifecycle coverage for starting/stopping the mautrix syncer.How to Test
python -m pytest tests/gateway/test_matrix.py -q -x --timeout=60→152 passed.python -m pytest tests/ -q -x --timeout=60→ stopped attests/acp/test_approval_isolation.py::TestAcpExecAskGate::test_interactive_env_var_routes_to_callback; this ACP approval-path failure is outside the Matrix gateway files changed by this PR.python -m ruff check gateway/platforms/matrix.py tests/gateway/test_matrix.py→ passed.python scripts/check-windows-footguns.py gateway/platforms/matrix.py tests/gateway/test_matrix.py→ passed.git diff --check→ passed.python -m ruff format --check gateway/platforms/matrix.py tests/gateway/test_matrix.py→ reported pre-existing whole-file formatting churn in these Matrix files, so no broad formatter rewrite was applied.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A.