fix: allow Desktop remote gateway file origins#37722
Closed
robertvoy wants to merge 1 commit into
Closed
Conversation
Author
|
Closing in favor of #37747, which carries the same Desktop remote gateway origin fix on a NousResearch branch with broader origin-guard regression coverage and passing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Origin: file://after dashboard session-token auth./api/wsconnection behavior.Why
Test remotecan pass because it uses REST, whileSave and reconnectfails because the Electron renderer opens a WebSocket with afile://origin. Previously Hermes only allowed that non-web origin on loopback binds, which breaks explicit remote Desktop mode over a trusted/tailnet backend guarded by the session token.Test plan
python -m pytest tests/hermes_cli/test_web_server.py::TestPtyWebSocket::test_remote_desktop_file_origin_allowed_after_token -q -o 'addopts='