fix(dashboard): allow desktop websocket origins on remote binds#37644
Closed
DanBennettUK wants to merge 1 commit into
Closed
fix(dashboard): allow desktop websocket origins on remote binds#37644DanBennettUK wants to merge 1 commit into
DanBennettUK wants to merge 1 commit into
Conversation
Author
|
Closing this as superseded by the recent upstream Desktop/WebSocket origin changes. The current implementation of Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://,null,app://,hermes://) when the dashboard is explicitly bound to a non-loopback hosthttp/httpsoriginsContext
Hermes Desktop can connect from an Electron renderer origin such as
file://. When using the dashboard remotely over a trusted private transport, the dashboard may be bound to a specific non-loopback address instead of localhost. The previous WebSocket origin guard rejected those Desktop origins with 403 even when a valid dashboard session token was supplied.This is framed as authenticated Desktop remote access rather than a Tailscale-specific special case.
Test plan
python -m py_compile hermes_cli/web_server.pypython -m pytest tests/hermes_cli/test_web_server_host_header.py -q -o 'addopts='\n\nLocal result:17 passed, 1 warning.\n