Fix desktop IME enter handling and gateway restart guards#37603
Open
nickytod wants to merge 1 commit into
Open
Fix desktop IME enter handling and gateway restart guards#37603nickytod wants to merge 1 commit into
nickytod wants to merge 1 commit into
Conversation
19 tasks
This was referenced Jun 3, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
systemctl stop/restartofhermes-gatewayservices from inside gateway sessions, even with yolo or approvals off.KillMode=control-groupand assert that generated units no longer useKillMode=mixed.Fixes #37483
Fixes #37453
Fixes #37454
Verification
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /opt/homebrew/bin/python3.11 -m pytest tests/tools/test_approval.py::TestGatewaySystemctlRestartGuard tests/hermes_cli/test_gateway_service.py::TestGeneratedSystemdUnits::test_user_unit_avoids_recursive_execstop_and_uses_extended_stop_timeout tests/hermes_cli/test_gateway_service.py::TestGeneratedSystemdUnits::test_system_unit_avoids_recursive_execstop_and_uses_extended_stop_timeout -q -o 'addopts='npm run type-check --workspace apps/desktopnpm run test:ui --workspace apps/desktop -- src/lib/ime.test.tsnpx eslint src/app/chat/composer/index.tsx src/components/assistant-ui/thread.tsx src/app/chat/sidebar/session-actions-menu.tsx src/components/desktop-onboarding-overlay.tsx src/lib/ime.ts src/lib/ime.test.ts