fix: quiet Slack control flow#36670
Open
jakelongvu-bot wants to merge 1 commit into
Open
Conversation
Author
|
Vucar staging is already patched and restarted (Hermes gateway PID 1231745). Targeted staging tests passed: |
This was referenced Jun 3, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLACK_ALLOWED_USERS,GATEWAY_ALLOWED_USERS, and paired-user store used for normal messagesGatewayRunnerto the Slack adapter so paired Slack users can approve actions from buttonsRoot Cause
Slack button interactions bypass the normal message authorization path in
gateway/run.py. That meant a user who was paired/authorized for Slack messages could still fail approval-button flows, and the gateway could post implementation-status noise into shared Slack channels.Validation
python -m py_compile gateway/platforms/slack.py gateway/run.py tests/gateway/test_slack_approval_buttons.py tests/gateway/test_busy_session_ack.pypython -m pytest tests/gateway/test_slack_approval_buttons.py tests/gateway/test_busy_session_ack.py -q(46 passed)git diff --check