feat(delegate): configurable max recursion depth#3633
Closed
Mibayy wants to merge 2 commits into
Closed
Conversation
Adds delegation.max_depth config option (default: 2) to limit nested delegation depth. Implementation: - _get_max_depth() reads from config.yaml delegation.max_depth - Falls back to 1 if config missing or invalid - Existing depth check in delegate_tool now uses configurable value Tests: - Default fallback to 1 - Reads from config when present - Handles missing/invalid config gracefully Allows power users to increase delegation depth while maintaining safe defaults.
Contributor
|
Thanks for the focused PR, @Mibayy! This feature landed on This is an automated hermes-sweeper review.
Note: this implementation uses the key |
Collaborator
|
Superseded by #13691 — merged PR that added orchestrator role and configurable max_spawn_depth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes delegation recursion depth configurable via
delegation.max_depthin config.yaml.What changed
delegation.max_depthconfig option (default: 2)_get_max_depth()reads from config, falls back to 1 if missing/invalidUse case
Power users can increase depth for complex multi-layer delegation workflows, while safe defaults (2 levels) remain for everyone else.
Tests
3 tests covering:
Part 3/3 of #3387 review response:
All three PRs are focused, tested, and contain zero rejected features (no DAG, blackboard, generator-critic, retry, checkpointing, or DELEGATION_GUIDANCE).