fix(config): ignore stale docker install-method stamp when .git exists (#35835)#36254
Open
Tranquil-Flow wants to merge 1 commit into
Open
fix(config): ignore stale docker install-method stamp when .git exists (#35835)#36254Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
NousResearch#35835) When $HERMES_HOME is a shared bind-mounted volume, the .install_method stamp from a prior official-image run persists after the user switches to a custom container that installed Hermes via git. The published image excludes .git via .dockerignore, so a .git directory at project_root is definitive proof the stamp is stale. - detect_install_method(): when stamp says 'docker' and .git exists, ignore the stale stamp and fall through to real detection - Auto-correct the stamp to the detected method so the user doesn't hit the stale-stamp guard again on next run - Updated test_stamp_file_takes_precedence to test the valid case (no .git dir → stamp wins) - Added test_stale_docker_stamp_with_git_falls_through for the stale-stamp recovery path with auto-correction verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
detect_install_method()reads a stale.install_methodstamp from a shared$HERMES_HOMEbin directory, it incorrectly reports 'docker' even when a.gitdirectory proves this is a pip install. The fix checks for.gitexistence first before trusting the stamp.Test Plan
Fixes #35835