fix: replace user-facing hardcoded ~/.hermes paths with display_hermes_home()#3623
Merged
Conversation
433a846 to
8f3b870
Compare
…s_home() Prep for profiles: user-facing messages now use display_hermes_home() so diagnostic output shows the correct path for each profile. New helper: display_hermes_home() in hermes_constants.py 12 files swept, ~30 user-facing string replacements. Includes dynamic TTS schema description.
8f3b870 to
8a88688
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second prep PR for profiles. User-facing messages (diagnostics, setup guidance, error troubleshooting) now show the correct HERMES_HOME path instead of hardcoded
~/.hermes. When profiles land,coder doctorwill correctly show~/.hermes/profiles/coder/.envinstead of~/.hermes/.env.New helper
display_hermes_home()inhermes_constants.py— returns a user-friendly~/...string:~/.hermes~/.hermes/profiles/coder/opt/hermes-custom(absolute, no~/)Changes
12 files, ~30 user-facing string replacements:
hermes_cli/doctor.pycli.pyrun_agent.pyhermes_cli/callbacks.pyhermes_cli/mcp_config.pyhermes_cli/skills_hub.pyhermes_cli/gateway.pyhermes_cli/setup.pyhermes_cli/auth.pytools/terminal_tool.pyhermes_cli/webhook.pyComments and docstrings left unchanged — only user-visible output affected.
Backward compat
For default
~/.hermesusers:display_hermes_home()returns~/.hermes— identical output. Zero visible change.Test plan
6645 passed, 201 skipped (1 pre-existing flaky unrelated to this PR). All modified files pass py_compile.