fix(google-workspace): remove unsupported metadataHeaders from gws binary path in gmail_reply#35894
Open
uzunkuyruk wants to merge 1 commit into
Open
Conversation
…rams in gmail_reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
gmail_reply, the_run_gwsbinary path passesmetadataHeadersinside theparamsdict. Thegwsbinary does not recognize this key when serialized as--paramsJSON, so the Gmail API returns no headers — causing_headers_dictto return an empty dict and losing theToandSubjectfields in the reply.The Python client path correctly uses
metadataHeadersas a keyword argument to.get(), which works fine and is left unchanged.Fix: Remove
"metadataHeaders"from theparamsdict in the_run_gwscall.Type of Change
References
Fixes #34806
Checklist