fix(google-workspace): handle Gmail header casing case-insensitively#35254
Merged
Conversation
Normalize Gmail API message header names to lowercase before lookup so gmail get/search/reply populate to/subject/from regardless of the casing the message was stored with. Emit conventional MIME header casing (To/Subject/Cc/From) on send and reply. Fixes #34806 Co-authored-by: Donovan Yohan <donovan-yohan@users.noreply.github.com>
Contributor
🔎 Lint report:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent tool execution no longer mutates checkpoint state for tool calls that get blocked. Previously the concurrent path ran checkpoint preflight before computing
block_result, so a blockedwrite_file/patch/destructiveterminalcould create a ghost checkpoint and steal the per-turn dedup slot from a later allowed write in the same directory — costing that allowed write its real pre-change snapshot.Root cause: ordering drift between the concurrent and sequential executors. The sequential path already gates checkpointing on
if not _execution_blocked; the concurrent path checkpointed first.Changes
agent/tool_executor.py: move concurrent-path checkpoint preflight to after block evaluation, gated onblock_result is None— matching the sequential invariant.tests/run_agent/test_run_agent.py: 4 tests — blocked write/patch/terminal skip checkpoint, and a blocked write doesn't steal the dedup slot from a later allowed write in the same dir.Validation
pytest -k concurrentSalvaged from #34856 by @beardthelion (cherry-picked, authorship preserved). Fixes #34827.
Infographic