fix(skills): handle read-only files when cleaning up skill sync backups#35182
Closed
TKwave wants to merge 1 commit into
Closed
fix(skills): handle read-only files when cleaning up skill sync backups#35182TKwave wants to merge 1 commit into
TKwave wants to merge 1 commit into
Conversation
sync_skills() uses shutil.rmtree(backup, ignore_errors=True) to clean up backup directories after a successful update. When files are read-only (e.g. read from a Nix store or mounted read-only filesystem), the removal fails silently and leaves .bak directories behind. These stale backups interfere with subsequent sync runs. Add a _rmtree_readonly() helper that catches PermissionError/readonly errors, flips the file writable with os.chmod, and retries the removal. Replace the silent-ignore rmtree call with this helper so backup cleanup succeeds even on read-only file trees.
Collaborator
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled skill sync leaves .bak directories when backup files are read-only (e.g. Nix store). The cleanup fails silently because shutil.rmtree(backup, ignore_errors=True) ignores errors.
Fix
Added _rmtree_readonly() helper that uses onerror handler to chmod read-only files before removal. Replaced the silent shutil.rmtree call.
Changes
Fixes #34860