fix(packaging): include mcp_serve in py-modules so hermes mcp serve works on pip installs#35044
Merged
Merged
Conversation
…orks on pip installs mcp_serve.py was missing from the setuptools py-modules list, causing hermes mcp serve to crash with ModuleNotFoundError on standard pip installs. Fixes NousResearch#34871
Collaborator
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the missing
mcp_servemodule to the setuptoolspy-moduleslist inpyproject.toml, fixinghermes mcp servecrashing withModuleNotFoundError: No module named 'mcp_serve'on standard pip installs.Related Issue
Fixes #34871
Type of Change
Changes Made
pyproject.toml: Added"mcp_serve"to the[tool.setuptools]py-moduleslist so the top-level module is included in built wheelsHow to Test
pip install hermes-agenthermes mcp serveModuleNotFoundError: No module named 'mcp_serve'Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/test_mcp_serve.py tests/hermes_cli/test_mcp_config*.py -qand all tests pass (119 passed)Documentation & Housekeeping
Code Intelligence
pyproject.toml(py-modules list),hermes_cli/mcp_config.py:794(from mcp_serve import run_mcp_server),mcp_serve.py(root module, 897 lines)Infographic