fix(delegate_task): accept caller-supplied model override#34472
Open
jiuri7758258-coder wants to merge 1 commit into
Open
fix(delegate_task): accept caller-supplied model override#34472jiuri7758258-coder wants to merge 1 commit into
jiuri7758258-coder wants to merge 1 commit into
Conversation
The delegate_task tool schema advertises a 'model' parameter but the function signature and handler lambda ignored it. - Add model param to delegate_task() signature - Pass model arg through handler lambda - Override creds['model'] with caller-supplied model - Support per-task model overrides - Propagate per-task provider alongside model
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
delegate_tasktool schema advertises amodelparameter but the functionsignature and handler lambda ignored it, so subagents always inherited the parent's
model regardless of what the caller specified.
Changes
modelparam todelegate_task()signaturecreds['model']with caller-supplied model after credential resolutionFixes the model-router skill pattern where
delegate_task(model={...})silently fell back to the parent model.