Skip to content

test(tui): stop notification pollers in session cleanup#34455

Open
violet-agent wants to merge 1 commit into
NousResearch:mainfrom
violet-agent:fix/tui-gateway-fake-agent
Open

test(tui): stop notification pollers in session cleanup#34455
violet-agent wants to merge 1 commit into
NousResearch:mainfrom
violet-agent:fix/tui-gateway-fake-agent

Conversation

@violet-agent

Copy link
Copy Markdown

Summary

  • add a test cleanup helper that stops TUI notification pollers before dropping sessions
  • update fake-agent session tests to use the helper instead of directly popping sessions
  • prevents orphan daemon pollers from consuming later process-completion events in CI

Test Plan

  • uv run --extra dev ruff check tests/test_tui_gateway_server.py
  • uv run --extra dev python -m pytest tests/test_tui_gateway_server.py -q
  • uv run --extra dev python -m pytest tests/test_tui_gateway_server.py::test_init_session_fires_reset_hook tests/test_tui_gateway_server.py::test_session_create_no_race_keeps_worker_alive tests/test_tui_gateway_server.py::test_session_create_continues_when_state_db_is_unavailable tests/test_tui_gateway_server.py::test_notification_poller_delivers_completion -q
  • uv run --extra all python scripts/run_tests_parallel.py --slice 1/6 (passed once; later rerun showed two unrelated/environmental failures: stale plugin discovery cache and a flaky MCP event bridge poll test)

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants