Skip to content

fix(acp): advertise slash commands#3417

Closed
NexVeridian wants to merge 1 commit into
NousResearch:mainfrom
NexVeridian:acp-advertise-slash-commands
Closed

fix(acp): advertise slash commands#3417
NexVeridian wants to merge 1 commit into
NousResearch:mainfrom
NexVeridian:acp-advertise-slash-commands

Conversation

@NexVeridian

Copy link
Copy Markdown
Contributor

What does this PR do?

ACP slash commands current do not work, since they exist but are not advertising correctly

see zed-industries/zed#41405 (comment)

In order for slash commands to work in Gemini/Qwen-Code, etc., the agents need to advertise them to Zed from their end as described in the docs

the docs to Advertising commands in acp https://agentclientprotocol.com/protocol/slash-commands

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

  1. install zed and add fixed zed acp config see docs(acp): fix zed config #2222
  2. open agent panel and go to hermes agent
  3. type and send /version or /help or any other slash command, just typing slash should also have a popup of all commands

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS 26.3

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

Before

see no popup
image

image

After

image image

@teknium1

teknium1 commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #5292. Your contribution (ACP slash command advertisement) was cherry-picked onto current main with your authorship preserved in git log. Thank you @NexVeridian!

@teknium1 teknium1 closed this Apr 5, 2026
@NexVeridian NexVeridian deleted the acp-advertise-slash-commands branch April 19, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants