fix(docker): validate HERMES_UID/GID to prevent privilege escalation in stage2-hook#34119
Closed
sprmn24 wants to merge 1 commit into
Closed
fix(docker): validate HERMES_UID/GID to prevent privilege escalation in stage2-hook#34119sprmn24 wants to merge 1 commit into
sprmn24 wants to merge 1 commit into
Conversation
Collaborator
|
Superseded by #35340, which landed in 758454d. Thanks for raising the privilege-escalation gap @sprmn24 — the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds numeric validation for
HERMES_UIDandHERMES_GIDenvironment variables before passing them tousermod/groupmodindocker/stage2-hook.sh.Type of Change
Changes Made
validate_uid_gid()helper function: rejects non-numeric values and enforces range 1000–65534HERMES_UIDandHERMES_GIDconditions with the validatorHERMES_UID=0orHERMES_GID=0from silently granting root-level privileges to the hermes userHow to Test
HERMES_UID=0→ usermod should NOT fireHERMES_UID=999→ usermod should NOT fireHERMES_UID=1001→ usermod fires normallyHERMES_GID=0→ groupmod should NOT fireChecklist