fix(cli): use session-scoped yolo bypass in /yolo command#34032
Open
sharziki wants to merge 1 commit into
Open
fix(cli): use session-scoped yolo bypass in /yolo command#34032sharziki wants to merge 1 commit into
sharziki wants to merge 1 commit into
Conversation
The CLI /yolo handler toggled HERMES_YOLO_MODE in os.environ, but approval.py freezes that flag at module-import time to prevent prompt-injection escalation. The env var flip had no effect on the already-frozen _YOLO_MODE_FROZEN bool, so /yolo appeared to enable YOLO (status bar showed ⚠ YOLO) while every dangerous command still hit an approval prompt. Switch to the same enable_session_yolo / disable_session_yolo path that the gateway and TUI handlers already use, keyed on the current approval session key. This makes /yolo actually bypass approvals for the active CLI session without weakening the import-time freeze that guards against programmatic escalation. Closes NousResearch#33925 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/yolotoggledHERMES_YOLO_MODEinos.environ, butapproval.pyfreezes that flag at module-import time (_YOLO_MODE_FROZEN) to prevent prompt-injection escalation — the env var flip had no effectenable_session_yolo()/disable_session_yolo()keyed onget_current_session_key(), matching how the gateway and TUI handlers already work/yolonow actually bypasses approvals for the active CLI session without weakening the import-time freezeTest plan
test_cli_toggle_yolo_uses_session_yolointests/tools/test_yolo_mode.pyCloses #33925
🤖 Generated with Claude Code