fix: add self-termination guard for pkill/killall targeting hermes/gateway#3400
Closed
arasovic wants to merge 1 commit into
Closed
fix: add self-termination guard for pkill/killall targeting hermes/gateway#3400arasovic wants to merge 1 commit into
arasovic wants to merge 1 commit into
Conversation
…teway (NousResearch#3397) A Telegram gateway agent ran `pkill -f "cli.py --gateway"` and killed its own process. This pattern was not caught by DANGEROUS_PATTERNS. Add a pattern to detect pkill/killall commands targeting hermes, gateway, or cli.py processes, triggering the existing approval flow. Closes NousResearch#3397
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Telegram gateway agent ran
pkill -f "cli.py --gateway"and killed its own process. This command is not caught by any existingDANGEROUS_PATTERNSentry — the currentpkillpattern only matchespkill -9(force kill), notpkill -f(filter by name).This is a variant of #2617, where the agent killed the gateway via
kill PID+&disown.Closes #3397
Changes
tools/approval.py— Add one pattern toDANGEROUS_PATTERNS:tests/tools/test_approval.py— 4 new tests:pkill -f "cli.py --gateway"→ detectedkillall hermes→ detectedpkill -f gateway→ detectedpkill -f nginx→ not flagged (unrelated process)Test plan
python -m pytest tests/tools/test_approval.py -q— 91 passed, 0 failed