fix(cron): handle null deliver field in cron list command#33870
Open
JackJoltClick wants to merge 1 commit into
Open
fix(cron): handle null deliver field in cron list command#33870JackJoltClick wants to merge 1 commit into
JackJoltClick wants to merge 1 commit into
Conversation
The cron list command was crashing with TypeError when a job had a null deliver field. Added null check to default to 'local' delivery when deliver is None.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32896
The
hermes cron listcommand was crashing withTypeError: can only join an iterablewhen a cron job had a null deliver field.Changes
cron_list()to default to['local']when deliver is NoneHow to Test
hermes cron listPlatform
Tested on macOS