feat(skills): add garrytan/gstack as default Skills Hub tap#3386
Closed
tugrulguner wants to merge 1 commit into
Closed
feat(skills): add garrytan/gstack as default Skills Hub tap#3386tugrulguner wants to merge 1 commit into
tugrulguner wants to merge 1 commit into
Conversation
Add garrytan/gstack to GitHubSource.DEFAULT_TAPS so that gstack skills (review, ship, qa, design-review, etc.) are discoverable via `hermes skills search gstack` without users needing to know the exact repo path. Also fix skill identifier construction in _list_skills_in_repo to avoid double slashes when a tap's path is empty (root-level skills). Closes NousResearch#3224
676ad7f to
c79d26b
Compare
Contributor
|
Merged via #3601 — cherry-picked onto current main with authorship preserved. Thanks @tugrulguner! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
garrytan/gstacktoGitHubSource.DEFAULT_TAPSintools/skills_hub.pyso that gstack skills are discoverable viahermes skills search.Also fixes a minor bug in
_list_skills_in_repowhere an emptypathin a tap would produce double-slash identifiers (e.g.garrytan/gstack//reviewinstead ofgarrytan/gstack/review).Why
gstack (51k+ stars, 6.6k forks) is a popular collection of opinionated agent skills by Garry Tan. Individual skills can already be installed via
hermes skills install garrytan/gstack/<skill>, but without a tap entry, users cannot discover them throughhermes skills search gstackorhermes skills browse.This was requested in #3224, and as noted by @Mibayy in the issue comments, adding the tap is a one-liner — the existing
GitHubSourcemachinery handles the rest.Changes
tools/skills_hub.pyline 251: Added{"repo": "garrytan/gstack", "path": ""}toDEFAULT_TAPS(skills live at the repo root, not in askills/subdirectory)tools/skills_hub.pyline 399: Fixedskill_identifierconstruction to avoid double slashes when tap path is emptyHow to test
hermes skills search gstack— gstack skills (review, ship, qa, design-review, etc.) should appear in resultshermes skills install garrytan/gstack/review— should install successfullyVerified
garrytan/gstack/review(notgarrytan/gstack//review)Platform tested
Test results
Closes #3224