fix(api-server): improve CORS headers#3384
Closed
aydnOktay wants to merge 2 commits into
Closed
Conversation
Contributor
|
Merged via PR #3530. Your Idempotency-Key CORS fix was cherry-picked onto current main with authorship preserved. The Vary: Origin middleware changes were dropped since that behavior already exists in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two small, high-impact CORS improvements for the API server:
Idempotency-KeyinAccess-Control-Allow-Headersso browser clients can use idempotency safely.Vary: Originis set for CORS responses to prevent cache/proxy mix-ups between different origins.Tests:
Idempotency-Keyis allowed on preflight andVary: Originis returned for allowed origins.