fix(cron): exclude jobs.json registry from disk-cleanup pattern#33834
Closed
sweetcornna wants to merge 1 commit into
Closed
fix(cron): exclude jobs.json registry from disk-cleanup pattern#33834sweetcornna wants to merge 1 commit into
sweetcornna wants to merge 1 commit into
Conversation
Contributor
|
Merged via #34840. Your disk-cleanup fix was cherry-picked onto current main with your authorship preserved in git log (commit d473e7c). This was the cleanest of the competing fixes — |
This was referenced May 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/disk-cleanup/disk_cleanup.py::guess_category()classified every top-level path underHERMES_HOME/cron/(and the legacycronjobs/alias) ascron-output, which made the durable scheduler registry (~/.hermes/cron/jobs.json,.tick.lock) eligible for automatic deletion.cron-outputlabel tocron/output/**only, matching the actual disposable-artifact subtree. Top-level cron control-plane files now returnNoneand are never auto-tracked.test_cron_subtree_categorisedto use a realcron/output/path and add three regression tests coveringjobs.json,.tick.lock, and thecronjobs/alias.Closes #32164
Test plan
python3 -m pytest tests/plugins/test_disk_cleanup_plugin.py::TestGuessCategory— 9/9 pass (3 new regression tests + adjusted cron-output test).top == "cron"blanket classification.