fix(honcho): include manager-scoped honcho.json settings in gateway cache signature#33440
Open
Dusk1e wants to merge 1 commit into
Open
fix(honcho): include manager-scoped honcho.json settings in gateway cache signature#33440Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gateway cache signature only fingerprints Honcho peer-mapping fields today, but
HonchoSessionManagerfreezes a wider config subset at init. As a result, somehoncho.jsonedits are ignored until an unrelated cache eviction or restart rebuilds the cached agent.This patch extends the Honcho cache-busting subset to include the manager-scoped settings that are baked into
HonchoSessionManagerconstruction, and adds regression coverage for those settings.Problem
HonchoSessionManagersnapshots settings like:contextTokenswriteFrequencydialecticReasoningLeveldialecticDynamicdialecticMaxCharsmessageMaxCharsdialecticMaxInputCharsBut the gateway cache signature only covered peer routing / identity fields. That meant editing those manager-scoped settings in
honcho.jsonwould not take effect on the next gateway message if the cached agent was reused.Fix
Extend
GatewayRunner._extract_cache_busting_config()to fingerprint the manager-scoped Honcho settings that are frozen byHonchoSessionManagerat init.Add regression coverage verifying that changing each of these settings changes both:
Tests
Ran:
tests/honcho_plugin/test_pin_peer_name.pytests/gateway/test_agent_cache.pyPrecedent
This follows the same cache-busting pattern established in: