[codex] Redact request debug dumps#33322
Open
egilewski wants to merge 1 commit into
Open
Conversation
Redact request debug dump payloads before writing them to disk or optional stdout. The dump redactor handles sensitive key names such as Authorization, api_key, client_secret, cookies, tokens, credentials, and private keys, and force-runs string redaction even when normal log redaction is disabled. Fixes NousResearch#19202 and NousResearch#18707.
b36551c to
a729706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authorization,api_key,client_secret, cookies, tokens, credentials, and private keys as fully redacted.Fixes #19202.
Fixes #18707.
Validation
python -m py_compile agent/agent_runtime_helpers.py tests/run_agent/test_run_agent_codex_responses.pygit diff --check HEAD^ HEADFull pytest was not run locally because this workspace has no usable
.venv/venvand system Python is missing test dependencies such as pytest/PyYAML.