fix(codex): update silent-hang workaround hint + wire into TTFB watchdog#33133
Merged
Conversation
Contributor
🔎 Lint report:
|
Collaborator
|
Salvage of #33034 by @EvilHumphrey onto current main. Supersedes closed #33128 (same author's earlier attempt that only fixed the stale-call hint without the TTFB wiring). |
14 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #33034 (@EvilHumphrey) onto current main.
Summary
The Codex silent-hang hint for ChatGPT OAuth accounts recommended
gpt-5.4-codexas the workaround for intermittentgpt-5.5no-TTFB / stale-call failures. That model name doesn't exist in the OpenAI Codex catalog — users following the hint hit a second error trying to switch to a phantom model.The actual workarounds:
gpt-5.4— real sibling model, works on the same OAuth profilegpt-5.3-codex— the actual Codex-tagged variantThis PR also wires the same hint into the TTFB watchdog kill path in
agent/chat_completion_helpers.py— that's the path most users actually hit first ongpt-5.5no-first-byte failures (e.g. the CRUSADER report in support thread getting "No first byte from provider"), not the stale-call timeout path.Changes
run_agent.py: hint text now recommendsgpt-5.4andgpt-5.3-codex;gpt-5.4-codexkept only as a caveat ("unsupported on some ChatGPT Codex accounts")agent/chat_completion_helpers.py: TTFB watchdog now calls_codex_silent_hang_hintand appends it to the user-facing status when killing a stale connectiontests/agent/test_codex_ttfb_watchdog.py: new coverage for the TTFB watchdog pathtests/run_agent/test_codex_silent_hang_hint.py: updated assertions for the new hint textValidation
gpt-5.4-codex(phantom)gpt-5.4+gpt-5.3-codex(real)Attribution
Cherry-picked from @EvilHumphrey's #33034. AUTHOR_MAP updated in follow-up commit. Original PR superseded #33128 (my earlier attempt that only fixed the stale-call hint without the TTFB wiring) — that one is closed with credit pointer.
User reports addressed: CRUSADER (Discord support, getting "No response from provider for 90s" with the misleading
gpt-5.4-codexsuggestion).Infographic