Skip to content

fix(gateway): reset _last_flushed_db_idx when reusing cached agent#32760

Open
ArgoBaseBot wants to merge 1 commit into
NousResearch:mainfrom
ArgoBaseBot:fix/agent-cache-reset-flushed-db-idx
Open

fix(gateway): reset _last_flushed_db_idx when reusing cached agent#32760
ArgoBaseBot wants to merge 1 commit into
NousResearch:mainfrom
ArgoBaseBot:fix/agent-cache-reset-flushed-db-idx

Conversation

@ArgoBaseBot

Copy link
Copy Markdown

Cached AIAgent instances retain _last_flushed_db_idx from previous turns. When the agent is reused, the stale index causes _flush_messages_to_session_db to skip user messages that fall below the old flush cursor, silently dropping them from state.db. This manifests as persistent context loss — every turn shows history=0 even after multiple exchanges.

Reset the flush cursor in _init_cached_agent_for_turn so each turn starts with a clean flush state.

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

Cached AIAgent instances retain _last_flushed_db_idx from previous
turns. When the agent is reused, the stale index causes
_flush_messages_to_session_db to skip user messages that fall below
the old flush cursor, silently dropping them from state.db.
This manifests as persistent context loss — every turn shows
history=0 even after multiple exchanges.

Reset the flush cursor in _init_cached_agent_for_turn so each turn
starts with a clean flush state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder comp/gateway Gateway runner, session dispatch, delivery P1 High — major feature broken, no workaround type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants