fix(db): preserve message timestamps across fork/compress/branch (#28841)#32522
Open
Jiahui-Gu wants to merge 1 commit into
Open
fix(db): preserve message timestamps across fork/compress/branch (#28841)#32522Jiahui-Gu wants to merge 1 commit into
Jiahui-Gu wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28841.
Summary
SessionDB.append_messagenow accepts an optionaltimestamp: float. When omitted it falls back totime.time()(existing behavior).SessionDB.replace_messagesreadsmsg["timestamp"]per row and only synthesizes a monotonically-increasingnow_tsfor messages that lack one. This stops/compress,/retryand/undofrom rewriting wall-clock times to the rewrite moment.run_agent.py,cli.py,gateway/run.py,gateway/session.py,gateway/mirror.py,tui_gateway/server.py) now forwardmsg.get("timestamp")so/branchand mirror writes preserve origin times.Tests
Added
TestMessageTimestampPreservationintests/test_hermes_state.py(8 tests): explicit timestamp, default-now fallback,0.0epoch is honored,replace_messagesround-trip preserves, fallback assigns distinct increasing times, mixed explicit/missing, fork-chain preservation, and repeated-compress no-drift.Test plan
pytest tests/test_hermes_state.py::TestMessageTimestampPreservation/compress, querySELECT timestamp FROM messages— original times retained./branch— child session keeps parent timestamps.