fix(skills): use atomic_json_write for LockFile and TapsManager#32233
Closed
sprmn24 wants to merge 1 commit into
Closed
fix(skills): use atomic_json_write for LockFile and TapsManager#32233sprmn24 wants to merge 1 commit into
sprmn24 wants to merge 1 commit into
Conversation
Collaborator
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LockFile.save()andTapsManager.save()writelock.jsonandtaps.jsonusingwrite_text(), which is non-atomic. If the process is killed or crashes mid-write (e.g. OOM, SIGKILL, power loss), the target file is left partially written and JSON-corrupt. On the next runload()falls back to an empty default — silently discarding all installed-skill records or all custom taps.Switches both methods to
atomic_json_writefromutils, which writes to a temp file, fsyncs, thenos.replaces — guaranteeing the old file survives intact if the write doesn't complete.Type of Change
Changes Made
tools/skills_hub.py: replacewrite_textwithatomic_json_writeinLockFile.save()andTapsManager.save()How to Test
hermes skills hub tap some/repotaps.jsonis not corrupted on next readhermes skills install→ kill → re-runhermes skills listChecklist