fix(dashboard): correct approvals.mode select options#31933
Open
Hopfensaft wants to merge 1 commit into
Open
Conversation
The web UI CONFIG_SCHEMA showed ['ask', 'yolo', 'deny'] for the approvals.mode select field. These don't match any real config values and 'smart' mode was entirely unreachable from the dashboard. Correct the options to ['manual', 'smart', 'off'] which match the values defined and documented in hermes_cli/config.py. Adds a regression test to TestBuildSchemaFromConfig to pin the correct option names and guard against future drift. Fixes NousResearch#31925
|
Verified against the config source — this is correct. The real
The old One optional note (not blocking): |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web UI
CONFIG_SCHEMAinhermes_cli/web_server.pyshowed['ask', 'yolo', 'deny']as the options forapprovals.mode. These are stale names that don't correspond to any real config values — andsmartmode was entirely missing, making it unreachable from the dashboard.Changes
hermes_cli/web_server.py: correctedapprovals.modeoptions from['ask', 'yolo', 'deny']to['manual', 'smart', 'off']to match the values defined inhermes_cli/config.pytests/hermes_cli/test_web_server.py: addedtest_approvals_mode_options_match_config_valuestoTestBuildSchemaFromConfigto pin the correct option names and guard against future driftTesting
Verified locally via the dashboard UI — all three options render correctly and selecting each writes the right config value without errors.
Closes #31925